Add namespace information to AppListItem #4912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
|
@smerschjohann, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
smerschjohann
force-pushed
the
smerschjohann/issue4896
branch
from
9e2eb83 to
a239b20
Compare
Yeah, I saw that already. It was a bit complicated, to find out that those were different failures and had nothing todo with my commit. But, I figured that out already ;) I'm looking forward to it :) |
|
@smerschjohann, VMware has approved your signed contributor license agreement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
It adds the Namespace to the description in the AppViewItem
Benefits
One can differentiate the installed packages of different namespaces
Possible drawbacks
none
Applicable issues