Remove temporary cmd arg for assetsvc #4963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
castelblanque
approved these changes
Jun 28, 2022
|
And after the v2.4.6 release in the bitnami index, the CI is green again. Merging and closing issue :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
When triggering the release, we noticed some failures in the "upgrade chart" test case due to some assetsvc-related params being still used. We decided to postpone the removal until de v2.4.6 was out.
This PR is simply removing this unused cmd argument.
Benefits
No more assetsvc-related code.
Possible drawbacks
N/A
Applicable issues
Additional information
CI will fail unless Bitnami releases the new chart version :S