-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct config for additional clusters #5034
Use correct config for additional clusters #5034
Conversation
✅ Deploy Preview for kubeapps-dev ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site settings. |
Thanks for the contribution @XenoAura ! LGTM, however, could you add a unit test so that we can avoid future regressions (we are planning to deprecate Kubeops and move the logic to the kubeapps-apis service) ? Additionally, it seems the CircleCI checks are not passing (I mean, not failing, just that, sometimes, they don't get reported back, perhaps you need an empty commit or just merging |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Forgot to actually +1 the changes 😅 , just waiting for the test to merge it.
Let me update the branch with the latest changes (mainly to trigger the CI checks, which were somehow stuck). Also, the CLA bot complained about the signing process, please let us know if you are facing any issues with it. Feel free to reach out to us in Slack. |
1 similar comment
@XenoAura , is there anything I can help you with the CLA issues the bot is reporting? Or maybe with the unit test? |
Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
* Added logic from #5034 Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Move the SA token to its own client getter Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Added missing error check Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Fix for return value Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Setting additional SA token dynamically Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> * Fix wrong command Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com> Signed-off-by: Rafa Castelblanque <rcastelblanq@vmware.com>
Fix: #5033
Description of the change
clientsetForConfig
uses incorrect cluster config variablekubeapps/pkg/kube/kube_handler.go
Lines 333 to 336 in 11c8792
Benefits
Correct behavior for getting a list of namespaces for additional clusters
Possible drawbacks
Applicable issues
Additional information