AppList and AppListItem render tests #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migmartri
approved these changes
Aug 22, 2018
| const wrapper = shallow( | ||
| <AppList | ||
| apps={ | ||
| { |
There was a problem hiding this comment.
Something that helps me to avoid repetition is the creation of a set of defaultProps and then detructure them. You might want to do the same.
prydonius
approved these changes
Aug 22, 2018
| import AppList from "./AppList"; | ||
| import AppListItem from "./AppListItem"; | ||
|
|
||
| it("renders a loading message if the app overview is not ready", () => { |
There was a problem hiding this comment.
I had to figure out what "app overview is not ready" meant, maybe just "if apps object is empty" is easier to understand?
| filter="" | ||
| />, | ||
| ); | ||
| expect( |
There was a problem hiding this comment.
a snapshot might be easier here than having to check for this exact text
There was a problem hiding this comment.
yes, in this case it'll be handy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic unit tests
fixes #518