ignore no charts error when filtering #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would display the No Charts Found error alert if the filtered chart array came back empty. However, this error only makes sense to show when the charts from the server come back empty. This patch fixes this to only show the error if there are no charts from the server. We may want to improve the way we show this message (for example, under the Charts header), and we may also want to show a different alert if the filter shows up empty in the future.
migmartri
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we would display the No Charts Found error alert if the
filtered chart array came back empty. However, this error only makes
sense to show when the charts from the server come back empty. This
patch fixes this to only show the error if there are no charts from
the server.
We may want to improve the way we show this message (for example, under
the Charts header), and we may also want to show a different alert if
the filter shows up empty in the future.
fixes #531