New deployment forms: changes in operator-related views #5411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nstead Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
dashboard/src/shared/schema.ts
Outdated
| @@ -4,9 +4,9 @@ | |||
| import Ajv, { ErrorObject, JSONSchemaType } from "ajv"; | |||
| import * as jsonpatch from "fast-json-patch"; | |||
| import * as yaml from "js-yaml"; | |||
| import { isEmpty, set } from "lodash"; | |||
| import _ from "lodash"; | |||
There was a problem hiding this comment.
Why using _ instead of importing the needed functions?
There was a problem hiding this comment.
You're right, we should import them explicitly (see this benchmark). I just added some ongoing changes in my working branch, where I just used the usual _ import for lodash, but we should decrease the bundle size when possible. Thanks!
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Before start adding deep changes to the deployment form, this PR is extracting those views related to operators (which will get refactored once we encapsulate the operators as a plugin) and aligning the views to the new "in-line diff editor".
Therefore, the old (and pretty unmaintained)
Differentialcomponent, has been removed in these views (but they have not in the non-operators ones for now).Also, adding a couple of minor changes in the utility functions.
Benefits
The non-operator-related views can be now safely modified in subsequent PRs.
Possible drawbacks
N/A
Applicable issues
Additional information
I'll be stacking more PRs on top of this one.