Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump google-protobuf from 3.21.0 to 3.21.2 in /dashboard #5471

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 18, 2022

Bumps google-protobuf from 3.21.0 to 3.21.2.

Release notes

Sourced from google-protobuf's releases.

v3.21.2

This is a hotfix release for #141

v3.21.1

  • Enable Closure's advanced optimization mode by default. This should reduce code size (#124).
  • Replace goog.testing.asserts in tests with Jasmine expectations (#136).
  • Bring in the subset of the goog.asserts we use as jspb.asserts. This code retains an Apache 2.0 license.
  • Fix decoding of signed varint32s (#31).
  • Add license files to NPM package.

This will also be our first release to have cross-compiled protoc-gen-js binaries. Please note that they use dynamic linking (similar to the protobuf protoc releases).

Changelog

Sourced from google-protobuf's changelog.

"""Generates package naming variables for use with rules_pkg."""

load("@​rules_pkg//:providers.bzl", "PackageVariablesInfo") load("@​bazel_tools//tools/cpp:toolchain_utils.bzl", "find_cpp_toolchain")

_PROTOBUF_JAVASCRIPT_VERSION = "3.21.2"

def _package_naming_impl(ctx): values = {} values["version"] = _PROTOBUF_JAVASCRIPT_VERSION

infer from the current cpp toolchain.

toolchain = find_cpp_toolchain(ctx) cpu = toolchain.cpu system_name = toolchain.target_gnu_system_name

rename cpus to match what we want artifacts to be

if cpu == "systemz": cpu = "s390_64" elif cpu == "aarch64": cpu = "aarch_64" elif cpu == "ppc64": cpu = "ppcle_64"

use the system name to determine the os and then create platform names

if "apple" in system_name: values["platform"] = "osx-" + cpu elif "linux" in system_name: values["platform"] = "linux-" + cpu elif "mingw" in system_name: if cpu == "x86_64": values["platform"] = "win64" else: values["platform"] = "win32" else: values["platform"] = "unknown"

return PackageVariablesInfo(values=values)

package_naming = rule( implementation=_package_naming_impl, attrs={ # Necessary data dependency for find_cpp_toolchain. "_cc_toolchain": attr.label( default=Label("@​bazel_tools//tools/cpp:current_cc_toolchain"),), }, toolchains=["@​bazel_tools//tools/cpp:toolchain_type"],

... (truncated)

Commits
  • e34549d Merge pull request #144 from dibenede/prepare-release
  • 60cbddd Bump version to 3.21.2
  • 64c19f8 Merge pull request #143 from dibenede/disable-optimizations
  • 0466dbc Add comment about default optimization level
  • c58937a Return to using default closure optimization level
  • 3b3a8ab Merge pull request #140 from dibenede/release-bugs
  • d99e404 Be explicit about all npm package files
  • d451e3b Fix typos in asserts add LICENSE-asserts.md to package.json
  • b792840 Merge pull request #139 from dibenede/prepare-release
  • f6d56c9 Run through pyformat to reduce whitespace diff
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [google-protobuf](https://github.com/protocolbuffers/protobuf-javascript) from 3.21.0 to 3.21.2.
- [Release notes](https://github.com/protocolbuffers/protobuf-javascript/releases)
- [Changelog](https://github.com/protocolbuffers/protobuf-javascript/blob/main/protobuf_javascript_release.bzl)
- [Commits](protocolbuffers/protobuf-javascript@v3.21.0...v3.21.2)

---
updated-dependencies:
- dependency-name: google-protobuf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Oct 18, 2022
@netlify
Copy link

netlify bot commented Oct 18, 2022

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 7b055ea
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/634e598d565a0b0009947d70

@antgamdia antgamdia merged commit 1b8cdd6 into main Oct 18, 2022
@antgamdia antgamdia deleted the dependabot/npm_and_yarn/dashboard/google-protobuf-3.21.2 branch October 18, 2022 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-not-required dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants