Run flux e2e test group in GHA's local_e2e_tests job #5625
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
beni0888
added
component/ci
antgamdia
approved these changes
Nov 10, 2022
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
absoludity
approved these changes
Nov 10, 2022
There was a problem hiding this comment.
I'll re-run the e2e test, looks like it failed this time while installing the source controller...
Waiting for deployment "helm-controller" rollout to finish: 0 of 1 updated replicas are available...
deployment "helm-controller" successfully rolled out
+ kubectl rollout status -w deployment/source-controller --namespace=flux-system
Waiting for deployment "source-controller" rollout to finish: 0 of 1 updated replicas are available...
error: deployment "source-controller" exceeded its progress deadline
Error: Process completed with exit code 1.
EDIT: appears to be failing consistently at that point :/
No idea why this would happen. Maybe we should have retries with |
gfichtenholt
added a commit
that referenced
this pull request
Nov 18, 2022
Original description from #5625 Description of the change It seems that at some point, a new flux test group has been added to the /script/e2e_test.sh file, but we have forgotten to add it to the GHA's local_e2e_tests job, so this test group is not being run in the GHA workflow. I have also took advantage of this PR to simplify the local_e2e_tests GHA job by setting a timeout of 6 minutes for every tests group, instead of having a default of 4 and setting it to 6 for the operator's group to avoid flaky tests. Benefits Run all the e2e tests from GHA. Possible drawbacks N/A
|
closing because merged PR #5656 has these changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jesús Benito Calzada bjesus@vmware.com
Description of the change
It seems that at some point, a new
fluxtest group has been added to the/script/e2e_test.shfile, but we have forgotten to add it to the GHA'slocal_e2e_testsjob, so this test group is not being run in the GHA workflow.I have also took advantage of this PR to simplify the
local_e2e_testsGHA job by setting a timeout of 6 minutes for every tests group, instead of having a default of 4 and setting it to 6 for the operator's group to avoid flaky tests.Benefits
Possible drawbacks
N/A
Applicable issues