Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in srp command #5649

Merged
merged 1 commit into from
Nov 17, 2022
Merged

Fix typo in srp command #5649

merged 1 commit into from
Nov 17, 2022

Conversation

beni0888
Copy link
Collaborator

Signed-off-by: Jesús Benito Calzada bjesus@vmware.com

Description of the change

This PR fixes a typo in the call to srp provenance source command in the GHA's srp-source-provenance action.

Benefits

A typo in the call to a command is removed, so it should work as expected now.

Possible drawbacks

None.

Applicable issues

Fix typo in srp command
77949f0 
Signed-off-by: Jesús Benito Calzada <bjesus@vmware.com>
@beni0888 beni0888 requested a review from absoludity November 16, 2022 20:53
@netlify
Copy link

netlify bot commented Nov 16, 2022 •
edited
Loading

✅ Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit 77949f0
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63754ddf5926c50008730d20

@beni0888 beni0888 marked this pull request as ready for review November 16, 2022 20:54
@beni0888 beni0888 self-assigned this Nov 16, 2022
@beni0888 beni0888 added component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code labels Nov 16, 2022
@beni0888 beni0888 added this to the Migrate CI to GitHub Actions milestone Nov 16, 2022
@gfichtenholt gfichtenholt self-requested a review November 16, 2022 21:02
gfichtenholt
gfichtenholt approved these changes Nov 16, 2022
View reviewed changes
Copy link
Contributor

@gfichtenholt gfichtenholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

absoludity
absoludity approved these changes Nov 17, 2022
View reviewed changes
Copy link
Contributor

@absoludity absoludity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you end up checking if you can run these locally? I'll try again with the tool I mentioned before, as it'd be great to be able to check these locally and avoid stuff. Thanks for all your efforts to see this through! It'll make it easy for us to switch and enjoy the benefits :)

@absoludity absoludity merged commit 998e16a into vmware-tanzu:main Nov 17, 2022
@beni0888 beni0888 deleted the fix-gha-srp-report branch November 17, 2022 06:12
@beni0888
Copy link
Collaborator Author

Did you end up checking if you can run these locally? I'll try again with the tool I mentioned before, as it'd be great to be able to check these locally and avoid stuff. Thanks for all your efforts to see this through! It'll make it easy for us to switch and enjoy the benefits :)

To be honest, I didn't check... 😓

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfichtenholt gfichtenholt gfichtenholt approved these changes

@absoludity absoludity absoludity approved these changes

Assignees

@beni0888 beni0888

Labels
cla-not-required component/ci Issue related to kubeapps ci system github_actions Pull requests that update GitHub Actions code
Projects
Kubeapps
Status: ✅ Done
Milestone
Migrate CI to GitHub Actions
Development

Successfully merging this pull request may close these issues.
4 participants
@beni0888 @absoludity @gfichtenholt @vmwclabot