Simple rename. #5704
Merged
Simple rename. #5704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppbaena
approved these changes
Nov 23, 2022
absoludity
force-pushed
the
5692-rename-values-default
branch
2 times, most recently
from
7c047de to
3915123
Compare
It confuses me every time I deal with the Values field in different parts of the code, since it's not user values at all, but the chart's default values file. Hopefully this will make it clearer. Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
5692-rename-values-default
branch
from
3915123 to
91ebd05
Compare
✅ Deploy Preview for kubeapps-dev canceled.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It confuses me every time I deal with the Values field in different parts of the code, since it's not user values at all, but the chart's default values file. Hopefully this will make it clearer.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
Simple refactor, changing the name. Nothing to review here (though VSCode's refactoring did create an extra file that I deleted, let's see what the automated tests do).
Benefits
Possible drawbacks
Applicable issues
Additional information