Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update asset-syncer to populate additional default files. #5786

Merged
merged 2 commits into from
Dec 20, 2022

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented Dec 9, 2022

Signed-off-by: Michael Nelson minelson@vmware.com

Description of the change

Updates the asset-syncer to fetch additional values files from a chart package and updates the helm plugin in kubeapps-apis to populate the AvailablePackageDetail with the additional values files when present.

Benefits

The dashboard can now be updated to use or display these when present.

Possible drawbacks

Applicable issues

Additional information

@absoludity absoludity marked this pull request as ready for review December 13, 2022 00:33
@absoludity absoludity force-pushed the 5692-refactor-oci-dry branch from 767848d to 6a767a7 Compare December 19, 2022 05:17
@absoludity absoludity force-pushed the 5692-additional-default-values-3.1 branch 3 times, most recently from 4974240 to adace23 Compare December 20, 2022 03:36
Base automatically changed from 5692-refactor-oci-dry to main December 20, 2022 04:31
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity force-pushed the 5692-additional-default-values-3.1 branch from adace23 to e54bdc7 Compare December 20, 2022 04:33
@netlify
Copy link

netlify bot commented Dec 20, 2022

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit e54bdc7
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/63a13b20ca685a0009032e86

Copy link
Collaborator

@ppbaena ppbaena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@absoludity absoludity merged commit 01cf950 into main Dec 20, 2022
@absoludity absoludity deleted the 5692-additional-default-values-3.1 branch December 20, 2022 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants