Update mongodb chart dependency #586
Conversation
chart/kubeapps/Chart.yaml
Outdated
| - dashboard | ||
| - service catalog | ||
| - deployment | ||
| - helm |
There was a problem hiding this comment.
this new indentation was automatically generated by the vscode editor
There was a problem hiding this comment.
It doesn't do that for me, do you have some sort of YAML lint extension or something? The rest of the chart (e.g. values.yaml) doesn't indent lists twice so we should keep it consistent with that for now.
There was a problem hiding this comment.
I don't, it's the normal editor.formatOnSave feature. I will disable it 😞
andresmgot
force-pushed
the
mongodbUpdate
branch
from
10cfb17 to
73dc77f
Compare
chart/kubeapps/Chart.yaml
Outdated
| - dashboard | ||
| - service catalog | ||
| - deployment | ||
| - helm |
There was a problem hiding this comment.
It doesn't do that for me, do you have some sort of YAML lint extension or something? The rest of the chart (e.g. values.yaml) doesn't indent lists twice so we should keep it consistent with that for now.
chart/kubeapps/Chart.yaml
Outdated
| @@ -1,19 +1,19 @@ | |||
| apiVersion: v1 | |||
| name: kubeapps | |||
| version: 0.3.2 | |||
| version: 0.3.3 | |||
There was a problem hiding this comment.
should it be a minor version bump since MongoDB is a minor version bump?
There was a problem hiding this comment.
I don't know the criteria in charts but for example with npm modules if a dependency gets updated it doesn't affect to the main version. Following the semver notation this is a "bug fix" so it should be a patch version bump.
There was a problem hiding this comment.
FYI @migmartri made an update to the chart which is 0.3.3, so please bump this one
Ref: #577