Leave slash in chart name encoded. Fixes #5897 #5970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Nelson <minelson@vmware.com>
✅ Deploy Preview for kubeapps-dev ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Michael Nelson minelson@vmware.com
Description of the change
In #3863 a change was made to ensure that we unescape spaces in the chart name before syncing data to the database, which unintentionally stopped Kubeapps from being able to retrieve charts that include a slash
/in the chart name (as is the case when using a unified repository with Harbor). It was noted on the PR as a possibility, but at the time, we didn't have non-OCI helm chart names with slashes that we were aware of, so we didn't follow it up.Benefits
A unified Harbor Helm repo can be used with Kubeapps.
Possible drawbacks
Haven't checked if the chart will display with the escaped slash or not, but still better to be able to display it rather than error.
Applicable issues
Additional information