add stylelint #601
add stylelint #601
Conversation
- replaces sass-lint - adds stylelint-config-prettier to ensure we don't conflict with prettier rules
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "extends": ["stylelint-config-recommended-scss", "stylelint-config-prettier"] | |||
There was a problem hiding this comment.
stylelint-config-recommended-scss is what stylelint recommends to use when using SCSS + prettier. However, this only enables the "possible errors" rules listed in https://github.com/stylelint/stylelint/blob/master/docs/user-guide/rules.md#possible-errors and none of the language feature rules. These are pretty basic rules, so I'm not sure if we'd want some of the more specific rules?
There was a problem hiding this comment.
I wouldn't add more rules if there are no good reasons to do so.
There was a problem hiding this comment.
I agree with @andresmgot, let's carry on with this and let's see how it goes.
BTW, remember to disable sass lint in your editor and install stylelint extension instead.
| "lint": "npm-run-all lint-js lint-css" | ||
| }, | ||
| "lint-staged": { | ||
| "*.{ts,tsx}": ["yarn run lint-js-fix", "prettier --write", "git add"], | ||
| "*.scss": ["yarn run lint-css-fix", "yarn run lint-css", "prettier --write", "git add"], | ||
| "*.scss": ["yarn run lint-css-fix", "prettier --write", "git add"], |
There was a problem hiding this comment.
so lint-css is not needed anymore? I thought that we wanted to add it as a guard before git add?
There was a problem hiding this comment.
sass-lint didn't have autofix so there was a separate tool for that, stylelint has it built in and will do the lint and fixing in one go, similar to tslint.
r.e. running prettier before linting, I think we should do that in a separate PR, and I'm still not 100% sure we should do that. I'd like to understand more about why it was in this order in the first place.
| @@ -0,0 +1,3 @@ | |||
| { | |||
| "extends": ["stylelint-config-recommended-scss", "stylelint-config-prettier"] | |||
There was a problem hiding this comment.
I wouldn't add more rules if there are no good reasons to do so.
As per the discussion in Slack (https://kubernetes.slack.com/archives/C9D3TSUG4/p1536314108000100), this PR switches to stylelint for better compatibility with prettier.
prettier rules