Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always show filter options #611

Merged
merged 2 commits into from
Sep 11, 2018
Merged

Always show filter options #611

merged 2 commits into from
Sep 11, 2018

Conversation

andresmgot
Copy link
Contributor

Fixes #593

  • Always show filter options even if the current list is empty
  • Always show the Deploy button in the top-right corner.
  • Remove Deploy button from welcome message to avoid duplicity

gif_2018-09-11_13 33 1536665629

@migmartri migmartri self-requested a review September 11, 2018 18:43
migmartri
migmartri approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks.

prydonius
prydonius approved these changes Sep 11, 2018
View reviewed changes
Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@prydonius
Copy link
Contributor

Merging this so @migmartri can build on top of this for #546

@prydonius prydonius merged commit 7d519b6 into vmware-tanzu:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prydonius prydonius prydonius approved these changes

@migmartri migmartri migmartri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andresmgot @prydonius @migmartri