Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition packaging plugins to Connect gRPC-Web #6183

Merged
merged 8 commits into from
Apr 13, 2023

Conversation

absoludity
Copy link
Contributor

@absoludity absoludity commented Apr 12, 2023

Description of the change

Updates the helm, kapp-controller and fluxv2 plugins to use the connect gRPC lib.

Benefits

Possible drawbacks

Applicable issues

Additional information

@netlify
Copy link

netlify bot commented Apr 12, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 64777bf
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/64379f495de9090008b451b3

Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity force-pushed the 6013-connect-grpc-backend-7 branch from a9f9a41 to c3e846c Compare April 12, 2023 02:16
Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity changed the title 6013 connect grpc backend 7 Transition packaging plugins to Connect gRPC-Web Apr 12, 2023
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity marked this pull request as ready for review April 13, 2023 06:22
@absoludity
Copy link
Contributor Author

Wooo - finally passes. So in the end this PR includes all 3 packaging plugins plus their corresponding repository plugins. The packaging plugins needed to be done together as the core packages service needs to treat them identically. And the repository plugins use much of the same functionality for getting clients etc.

@absoludity absoludity merged commit de9d44e into main Apr 13, 2023
@absoludity absoludity deleted the 6013-connect-grpc-backend-7 branch April 13, 2023 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants