Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rust and Javascript deps. #6210

Merged
merged 3 commits into from
Apr 19, 2023
Merged

Rust and Javascript deps. #6210

merged 3 commits into from
Apr 19, 2023

Conversation

absoludity
Copy link
Contributor

Description of the change

Just remaining dep updates for 2.7.0 release.

Signed-off-by: Michael Nelson <minelson@vmware.com>
@netlify
Copy link

netlify bot commented Apr 19, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 1599019
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/643f9882ecf74b0008551346

Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
@@ -26,7 +26,7 @@
"watch-css": "yarn run build-css && yarn run compile-lang && sass src/ --watch --no-source-map"
},
"dependencies": {
"@babel/parser": "^7.20.15",
"@babel/parser": "^7.18.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please note this change won't take effect unless the manual resolution under resolutions is also upgraded 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't it the other way around? yarn upgrade has set this dependency to ^7.18.4 because the manual resolution for this package is set to ^7.18.4? I'm not sure why it was here at 7.20.15 given the manual resolution.

@absoludity absoludity merged commit 08d23db into main Apr 19, 2023
@absoludity absoludity deleted the 2.7.0-release-updates-1 branch April 19, 2023 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants