Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure only single request for installed apps. #6568

Merged
merged 2 commits into from
Aug 6, 2023

Conversation

absoludity
Copy link
Contributor

Description of the change

Fixes an issue I'd noticed while upgrading react-router, in that sometimes the installed apps for the namespace would display, then seconds later, be updated with installed apps across all namespaces.

Benefits

No longer have this confusing UI behaviour.

Possible drawbacks

None.

Applicable issues

Signed-off-by: Michael Nelson <minelson@vmware.com>
@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 8936c4e
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/64ccc8ea748ad90008331860

Copy link
Contributor

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Good catch!

@@ -111,7 +103,7 @@ function AppList() {
/>
{canSetAllNS && (
<CdsToggleGroup className="flex-v-center">
<CdsToggle>
<CdsToggle data-testid="cds-all-ns">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this testid ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Argh - I'd added it when struggling to get the test to work, but forgot to remove. Thanks.

Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity merged commit 41e940a into main Aug 6, 2023
@absoludity absoludity deleted the installed-apps-double-dip branch August 6, 2023 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants