Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remaining version upgrades #6569

Merged
merged 19 commits into from
Aug 7, 2023
Merged

Conversation

antgamdia
Copy link
Contributor

Description of the change

As part of the clean-up I'm doing before tackling other issues, this PR is just bumping up some versions, in accordance to the release process.
Besides, I'm also adding the oci-catalog component to the proper files so it gets the same workflows (dependabot, license check, release process guide, etc...).

Benefits

Everything will be up-to-date again :)

Possible drawbacks

Hope any, but let's see what CI thinks.

Applicable issues

N/A

Additional information

N/A

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit e9f21fe
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/64d0faa24cc4d70008f3d0e4

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
schedule:
interval: "daily"
time: "02:30"
open-pull-requests-limit: 10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. We've not yet released a version with oci-catalog (nor are we using it yet in the codebase), but no reason not to start getting alerts, for sure.

Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>

Conflicts:
	cmd/pinniped-proxy/Cargo.lock
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
This reverts commit 3f555e0.
Copy link
Contributor Author

@antgamdia antgamdia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Find below some additional changes I had to perform after I ran into some issues after merging.

@@ -41,6 +41,7 @@ beforeEach(() => {
configurable: true,
value: jest.fn().mockImplementation(() => ({
clearRect: jest.fn(),
fillRect: jest.fn(),
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somehow, after merging the latest main, I noticed the dashboard tests were failing. It seems Monaco editor now requires fillRect in addition to the already mocked clearRect (this is from the Canvas API, which is unavailable in jsdom)

Comment on lines +201 to +204
# with 4 workers on a 7Gb (free plan) needs 1.75Gb of max old space. Forcing
# garbage collection to start earlier with 1024M per worker.
# See https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources
NODE_OPTIONS: "--max-old-space-size=1024"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since GHA now has 7GB of mem, I have updated the settings accordingly (I ran into some OOM errors today).

Comment on lines +40 to +44
const ignoredMgs = [
"Could not create web worker", // monaco uses web workers, but we don't need them for testing
"MonacoEnvironment.getWorkerUrl or MonacoEnvironment.getWorker", // monaco uses web workers, but we don't need them for testing
"react-tooltip.min.cjs", // react-tooltip complains about some tests without an "act()" wrapper
];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While debugging why the dashboard tests were hanging, I added this to ignore some known errors. This way, the output of the yarn test is more legible now.

@antgamdia antgamdia merged commit 7db08e1 into vmware-tanzu:main Aug 7, 2023
@antgamdia antgamdia deleted the more-upgrades branch August 7, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants