-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and push the dev oci-catalog image. #6594
Conversation
❌ Deploy Preview for kubeapps-dev failed.
|
✅ Deploy Preview for kubeapps-dev canceled.
|
Happy to see this PR. In fact, I had some stashed changes doing the same (I did it while upgrading versions), and forgot to ask you what to do with this new component. Find below my changes, just in case they can be of help. Full diffdiff --git a/.github/workflows/kubeapps-general.yaml b/.github/workflows/kubeapps-general.yaml
index 3dd0d5fdb..aff6192d2 100644
--- a/.github/workflows/kubeapps-general.yaml
+++ b/.github/workflows/kubeapps-general.yaml
@@ -39,7 +39,7 @@ env:
HELM_VERSION_MIN: "v3.8.0"
HELM_VERSION_STABLE: "v3.12.2"
GITHUB_VERSION: "2.32.1"
- IMAGES_TO_PUSH: "apprepository-controller dashboard asset-syncer pinniped-proxy kubeapps-apis"
+ IMAGES_TO_PUSH: "apprepository-controller dashboard asset-syncer pinniped-proxy oci-catalog kubeapps-apis"
# IMG_DEV_TAG is the tags used for the Kubeapps docker images. Ideally there should be an IMG_PROD_TAG
# but its value is dynamic and GitHub actions doesn't support it in the `env` block, so it is generated
# as an output of the `setup` job.
@@ -225,6 +225,17 @@ jobs:
- name: Run rust unit tests
run: cargo test --manifest-path cmd/pinniped-proxy/Cargo.toml
+ test_oci_catalog:
+ needs:
+ - setup
+ runs-on: ubuntu-latest
+ container:
+ image: rust:${{needs.setup.outputs.rust_version}}
+ steps:
+ - uses: actions/checkout@v3
+ - name: Run rust unit tests
+ run: cargo test --manifest-path cmd/oci-catalog/Cargo.toml
+
test_chart_render:
needs:
- setup
@@ -256,6 +267,7 @@ jobs:
- asset-syncer
- kubeapps-apis
- pinniped-proxy
+ - oci-catalog
steps:
- id: setup
run: |
@@ -408,6 +420,7 @@ jobs:
- test_go
- test_dashboard
- test_pinniped_proxy
+ - test_oci_catalog
- test_chart_render
- build_docker_images
- build_dashboard_image
@@ -730,6 +743,7 @@ jobs:
- test_go
- test_dashboard
- test_pinniped_proxy
+ - test_oci_catalog
- test_chart_render
- build_docker_images
- build_dashboard_image |
I have just noticed we would also need to get some scripts updated, for instance, |
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
0f552a1
to
4b87fc9
Compare
True - fixed. Thanks Antonio. |
Signed-off-by: Michael Nelson <minelson@vmware.com>
95d930a
to
2d3dfcf
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
2d3dfcf
to
3f6f4c3
Compare
Description of the change
While setting up the dev chart changes, just realised I hadn't yet updated to publish the dev image.
Benefits
Dev image for oci-catalog will be available.
Applicable issues
Additional information