Fix script to fetch the latest published container in dockerhub #6597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.Built without sensitive environment variables
|
absoludity
approved these changes
Aug 10, 2023
Comment on lines
+111
to
+115
| # Get the latest tag from the bitnami repository in DockerHub. | ||
| # Assumption: the more recent tag is the second one in the list after a reverse alphabetical sorting, | ||
| # first one is "latest", which we don't actually want. | ||
| local tag | ||
| tag=$(curl "${curl_opts[@]}" "https://hub.docker.com/v2/namespaces/bitnami/repositories/${repoName}/tags" | jq -r '.results[].name' | sort -r --version-sort | sed -n "2 {p;q}") |
There was a problem hiding this comment.
Nice - I'd not looked at switching from the non-existent GH repos to checking the dockerhub repo instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR is to actually fix #6220 by fetching from DockerHub the more recent (!=latest) published tag. I'm removing the workaround performed in #6237.
Benefits
The script will continue to work as initially expected.
Possible drawbacks
N/A
Applicable issues
Additional information
N/A