Sync chart with bitnami/kubeapps chart (version 12.4.10) #6658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Signed-off-by: kubeapps-bot <tanzu-kubeapps-team@vmware.com>
✅ Deploy Preview for kubeapps-dev canceled.
|
antgamdia
reviewed
Aug 18, 2023
Comment on lines
+7
to
+21
| images: | | ||
| - name: kubeapps-apis | ||
| image: docker.io/bitnami/kubeapps-apis:2.8.0-debian-11-r40 | ||
| - name: kubeapps-apprepository-controller | ||
| image: docker.io/bitnami/kubeapps-apprepository-controller:2.8.0-debian-11-r13 | ||
| - name: kubeapps-asset-syncer | ||
| image: docker.io/bitnami/kubeapps-asset-syncer:2.8.0-debian-11-r13 | ||
| - name: kubeapps-pinniped-proxy | ||
| image: docker.io/bitnami/kubeapps-pinniped-proxy:2.8.0-debian-11-r40 | ||
| - name: kubeapps-dashboard | ||
| image: docker.io/bitnami/kubeapps-dashboard:2.8.0-debian-11-r37 | ||
| - name: nginx | ||
| image: docker.io/bitnami/nginx:1.25.2-debian-11-r0 | ||
| - name: oauth2-proxy | ||
| image: docker.io/bitnami/oauth2-proxy:7.4.0-debian-11-r272 |
There was a problem hiding this comment.
We might need to check our sync scripts to ensure we are still performing the replacement properly.
Edit: or we can just ignore it, it is just an extra field they have added.
There was a problem hiding this comment.
Edit: or we can just ignore it, it is just an extra field they have added.
For now maybe, but longer term I assume we'd need to ensure this field also gets updated (probably related to being able to move/relocate the chart). EDIT: Ah, or you mean for our dev chart - yeah, I don't think we'll care there, true.
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
Signed-off-by: Antonio Gamez Diaz <agamez@vmware.com>
absoludity
approved these changes
Aug 20, 2023
Comment on lines
-1853
to
+1859
| ## @param dashboard.image.registry Dashboard image registry | ||
| ## @param dashboard.image.repository Dashboard image repository | ||
| ## @param dashboard.image.tag Dashboard image tag (immutable tags are recommended) | ||
| ## @param dashboard.image.digest Dashboard image digest in the way sha256:aa.... Please note this parameter, if set, will override the tag | ||
| ## @param dashboard.image.pullPolicy Dashboard image pull policy | ||
| ## @param dashboard.image.pullSecrets Dashboard image pull secrets | ||
| ## @param dashboard.image.debug Enable image debug mode | ||
| ## @param ociCatalog.image.registry OCI Catalog image registry | ||
| ## @param ociCatalog.image.repository OCI Catalog image repository | ||
| ## @param ociCatalog.image.tag OCI Catalog image tag (immutable tags are recommended) | ||
| ## @param ociCatalog.image.digest OCI Catalog image digest in the way sha256:aa.... Please note this parameter, if set, will override the tag | ||
| ## @param ociCatalog.image.pullPolicy OCI Catalog image pull policy | ||
| ## @param ociCatalog.image.pullSecrets Dashboard image pull secrets | ||
| ## @param ociCatalog.image.debug Enable image debug mode |
|
Landing this as there's another one queued up now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This is an automatic PR for synchronizing the changes performed externally at the bitnami/kubeapps official chart to the Kubeapps development version.
Benefits
The Kubeapps development chart will get the newest changes, including image version updates and other updates.
Possible drawbacks
Although unlikely, some changes implemented by the Bitnami team may not be 100% compatible with the current Kubeapps version.
Applicable issues
N/A
Additional information
This PR is marked as a draft until a Kubeapps maintainer manually reviews it.