Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass OCI Catalog URL through to syncer. #6720

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

absoludity
Copy link
Contributor

Description of the change

Updates the dev chart and snippets of code so that if the OCI-Catalog service is enabled, the URL is passed all the way through to the sync job.

Verified from the logs:

I0829 01:33:33.729325       1 root.go:32] "The component 'asset-syncer' has been configured with" serverOptions={"DatabaseURL":"kubeapps-postgresql:5432","DatabaseName":"assets","DatabaseUser":"postgres","DatabasePassword":"REDACTED","Debug":false,"Namespace":"default","OciRepositories":[],"TlsInsecureSkipVerify":false,"FilterRules":"","PassCredentials":false,"UserAgent":"asset-syncer/903124d9eb9976d7cad846331c20440132b143df (kubeapps/DEVEL)","UserAgentComment":"kubeapps/DEVEL","GlobalPackagingNamespace":"kubeapps","KubeappsNamespace":"","AuthorizationHeader":"","DockerConfigJson":"","OCICatalogURL":"kubeapps-internal-kubeappsapis:50061"}
I0829 01:33:34.926684       1 utils.go:495] Unable to find VAC index: .... Attempting OCI-Catalog
Error: error: GET request to [https://registry-1.docker.io/v2/bitnamicharts/airflow/tags/list] failed due to status [401]: {"errors":[{"code":"UNAUTHORIZED","message":"authentication required","detail":[{"Type":"repository","Class":"","Name":"bitnamicharts/airflow","Action":"pull"}]}]}

Benefits

Can start next step of getting an anon token to continue the sync.

Possible drawbacks

Applicable issues

Additional information

This should really have been done as part of the previous #6263 where I updated the sync code to use the new service, but didn't hook it up.

Signed-off-by: Michael Nelson <minelson@vmware.com>
@netlify
Copy link

netlify bot commented Aug 29, 2023

Deploy Preview for kubeapps-dev canceled.

Name Link
🔨 Latest commit 127d648
🔍 Latest deploy log https://app.netlify.com/sites/kubeapps-dev/deploys/64ed5c1e43767f0008b5c922

Signed-off-by: Michael Nelson <minelson@vmware.com>
@absoludity absoludity merged commit daabdfa into main Aug 29, 2023
@absoludity absoludity deleted the 6706-sync-public-oci-repo branch August 29, 2023 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants