6891 - Add _blank attribute to links on LinkRenderer to open urls on …

[vash-knives]

Description of the change

Fixes the #6891 ticket

Benefits

Opens a new tab for external links

Possible drawbacks

N/A

Applicable issues

• fixes Open links of "installation notes" in new tab #6891

Additional information

N/A

[netlify]

✅ Deploy Preview for kubeapps-dev canceled.

Built without sensitive environment variables

Name	Link
🔨 Latest commit	9bbd80a
🔍 Latest deploy log	https://app.netlify.com/sites/kubeapps-dev/deploys/65260cb22371fe0008b9a58e

[vmwclabot]

@vash-knives, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction.

[vmwclabot]

@vash-knives, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

[absoludity]

So every non-internal link for the dashboard-rendered markdown (Readme's, Notes) will be opened in a new tab - makes sense.

Thanks @vash-knives . Once the contributor agreement is approved, I'll land it.

[vash-knives]

@absoludity that is correct. i figured a user would prefer to be on the same tab if it's external. it does seem like on that "Notes.txt" it's mostly external links since it's for the chart's instructions anyway. I can update code if the internal should be on a new tab as well.

Also, anything I need to do for that contributor agreement goes through? I'm new to this so still trying to figure that out.

[absoludity]

@absoludity that is correct. i figured a user would prefer to be on the same tab if it's external. it does seem like on that "Notes.txt" it's mostly external links since it's for the chart's instructions anyway. I can update code if the internal should be on a new tab as well.

I think it's best as is (as internal links are internal to the page, not just the site), thanks :)

Also, anything I need to do for that contributor agreement goes through? I'm new to this so still trying to figure that out.

Nothing to do but wait at the moment, I assume it's waiting for someone to check a box which will automatically leave a comment here (as mentioned in the auto comment above), then we can land your change.

[vmwclabot]

@vash-knives, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Is this a genuine email address ? Do you have an alternative that you can provide please ?Also for address please provide minimum (Country, State, Town/City).

[vmwclabot]

@vash-knives, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

[vmwclabot]

@vash-knives, VMware has rejected your signed contributor license agreement. The merge can not proceed until the agreement has been resigned. Click here to resign the agreement. Reject reason:

Same comments as earlier today: please provide more address detail, and do you have an alternative email address please ?

[vmwclabot]

@vash-knives, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed.

[vmwclabot]

@vash-knives, VMware has approved your signed contributor license agreement.

[vash-knives]

ah finally! @absoludity , lmk if there's anything else i need to do.

[absoludity]

ah finally! @absoludity , lmk if there's anything else i need to do.

Excellent, but yeah, if you can, could you sign the commit? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits (you might need to uncommit, then sign the commit as per the link, then force push).

If you've had enough, no problem - I can land it as is since it's such a small change. Just let me know.

[vash-knives]

Excellent, but yeah, if you can, could you sign the commit? See https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits (you might need to uncommit, then sign the commit as per the link, then force push).

@absoludity So I got the gpg set up (eventually), see if that worked? I am not 100% I did it correctly. This is my first time signing using gpg, I appreciate your patience. Let me know if it did not work.

[absoludity]

@absoludity So I got the gpg set up (eventually), see if that worked? I am not 100% I did it correctly. This is my first time signing using gpg, I appreciate your patience. Let me know if it did not work.

Great, yes - that worked. You can see by looking at the commit https://github.com/vmware-tanzu/kubeapps/pull/6903/commits and seeing the "Verified" (if you click on it, it tells you its' verified by your gpg key). I'll re-run the workflow.

[vash-knives]

@absoludity nice, glad that worked!