6548 helm implementation #6997
Closed
6548 helm implementation #6997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Deploy Preview for kubeapps-dev failed.
|
absoludity
force-pushed
the
6548-core-implementation
branch
from
604a7c4 to
2c85414
Compare
Signed-off-by: Michael Nelson <minelson@vmware.com>
…rers. Signed-off-by: Michael Nelson <minelson@vmware.com>
… keep the state and add to the UX. Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
6548-helm-implementation
branch
from
cbcfc39 to
96ade56
Compare
absoludity
added a commit
that referenced
this pull request
Nov 16, 2023
…7088) ### Description of the change Splitting up changes in #6997 while adding proper tests etc. This PR updates the proto messages to the final desired output. ### Applicable issues <!-- Enter any applicable Issues here (You can reference an issue using #) --> - ref #7038 Signed-off-by: Michael Nelson <minelson@vmware.com>
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
antgamdia
removed
the
stale
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
stale
bot
added
the
stale
antgamdia
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
WIP: It requests the metadata from our API correctly, retreives and displays it in the available package details (see metadata on the left). Unfortunately I've not yet sorted how Harbor determines the artifact type as
application/vnd.oci.empty.v1+jsonrather than the types I'm setting when attaching, so they look identical other than the sha.Other things we'd want to do beyond this point:
Benefits
Possible drawbacks
Applicable issues
Additional information