Add typescript compilation check and hooks update #700
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue with tslint is that it actually does not check that the compilation works, from their documentation
So I've added a compilation step during the pre-hook. Please note that it was added in the husky hooks not in the
lint-staged
. This is because the compilation does not depend on the changed files (but on the tsconfig.json) so it can not be used there. More info hereCloses #694
Closes #158