Remove chart repo and chartsvc sources #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
reviewed
Oct 9, 2018
docs/architecture/overview.md
Outdated
| @@ -21,12 +21,3 @@ This proxy is written in Go. Check more details about the implementation in this | |||
| ### Apprepository CRD and Controller | |||
|
|
|||
| Chart repositories in Kubeapps are managed with a `CustomResourceDefinition` called `apprepositories.kubeapps.com`. Each repository added to Kubeapps is an object of type `AppRepository` and the `apprepository-controller` will watch for changes on those type of objects to update the list of available charts to deploy. | |||
|
|
|||
| ### `chart-repo` | |||
There was a problem hiding this comment.
we probably need to maintain some docs saying that chart-repo and chartsvc are not here, why and point to the their documentation
There was a problem hiding this comment.
You're right, let me update this
andresmgot
approved these changes
Oct 9, 2018
added 6 commits
October 9, 2018 15:21
prydonius
force-pushed
the
remove-chart-repo-chartsvc
branch
from
dc1a966 to
b026561
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #672 we decided upon moving the chart-repo and chartsvc sources to the https://github.com/helm/monocular and pulling in the built images from there. Now that the sources have been moved to that repo and the CI is building images, this PR removes the sources from this repo and updates the Helm charts and other documentation to reference the upstream images.
Commits have been separated for easier review of changes.
fixes #671