Adds implementation of Helm OCI refererrs endpoint. #7131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for kubeapps-dev canceled.
|
absoludity
commented
Nov 24, 2023
Comment on lines
-271
to
+275
| func newServerWithSecretsAndRepos(t *testing.T, secrets []k8sruntime.Object, unstructuredObjs []k8sruntime.Object, repos []*v1alpha1.AppRepository) *Server { | ||
| func newServerWithSecretsAndRepos(t *testing.T, secrets []k8sruntime.Object, repos []*v1alpha1.AppRepository) *Server { |
There was a problem hiding this comment.
I needed something similar to this function, which was created for the updated repository tests, but noticed that every call-site was simply creating the unstructured objects from the repos that were also passed in. So I refactored so call-sites don't need to create and pass the unstructured objects at all.
Including title and description annotations, with tests. Signed-off-by: Michael Nelson <minelson@vmware.com>
Signed-off-by: Michael Nelson <minelson@vmware.com>
absoludity
force-pushed
the
7038-helm-implementation-2
branch
from
3e0d376 to
d69030b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
After a small refactor to re-use an existing test function, this PR adds the implementation for fetching the referrers of an OCI chart.
This includes using the annotations in the referrers for the name/description returned (for better UX) as well as an http fake for handling the OCI requests in tests.
Applicable issues
Additional information