Update certs for e2e tests #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
merging this to fix master builds |
|
Why did it expire? Was it a mistake creating them in the first place? I am asking because I can see now the instructions on how to create them but they seem just informative right? Thanks for fixing it! |
The previous cert used the default expiration date of 30 days (now I set it to 7300)
It wasn't, we decided to commit them to save the time that it takes to generate them in the CI.
That's correct, it's just informative in case someone needs to regenerate them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the sample certs of the repo. The e2e tests were failing because the current cert has expired:
[debug] x509: certificate has expired or is not yet valid