-
Notifications
You must be signed in to change notification settings - Fork 705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add developer docs for chartsvc and chart-repo #775
docs: add developer docs for chartsvc and chart-repo #775
Conversation
The sources for these tools are in the Monocular repository, this adds documentation on how to develop these tools for Kubeapps from that repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't this documentation live in the Monocular repo?
docs/developer/chart-repo.md
Outdated
|
||
### Running in development | ||
|
||
#### Option 1: Using Telepresence (recommended) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this guide only have one option so I guess we can skip the heading
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good catch, thanks!
|
||
This builds the `chart-repo` Docker image. | ||
|
||
### Running in development |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't we just point here to the monocular repo? We are having duplicated documentation
Also this is likely to get outdated since the source code of this tool is not in this repo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See #775 (comment).
Also this is likely to get outdated since the source code of this tool is not in this repo.
But how often do we need to change the development workflow?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know that we don't update them very often
These commands are in the context of testing those tools against Kubeapps - so they reference the Deployment names of |
I know, it just seemed a bit weird to have those docs here. In any case they are adapted and are easy enough so I am fine having them here. |
The sources for these tools are in the Monocular repository, this adds
documentation on how to develop these tools for Kubeapps from that
repository.
fixes #754