Increase websockets idle timeout #790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydonius
approved these changes
Nov 7, 2018
| @@ -38,6 +38,9 @@ data: | |||
| # Hide Www-Authenticate to prevent it triggering a basic auth prompt in | |||
| # the browser with some clusters | |||
| proxy_hide_header Www-Authenticate; | |||
| # Keep the connection open with the API server even if idle. | |||
| # Default 60 seconds, see https://github.com/kubeapps/kubeapps/issues/766 | |||
There was a problem hiding this comment.
This comment is confusing, sounds like you're saying that we're defaulting it to 60s.
Suggested change
| # Default 60 seconds, see https://github.com/kubeapps/kubeapps/issues/766 | |
| # nginx defaults this to 60 seconds, we override it to 1h. See https://github.com/kubeapps/kubeapps/issues/766 |
|
Great find @migmartri, thanks for fixing! |
|
lgtm! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main issue was that websocket connections were being closed after 60 seconds of idle time.
This was because Nginx, which we use as a proxy has 60 seconds timeout by default. I have increased that idle timeout to 1 hour only in the
wslocation.I have tested it in my local deployment.
Fixes #766