Show correct release name in case of error #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prydonius
approved these changes
Nov 8, 2018
| @@ -102,7 +107,7 @@ class DeploymentForm extends React.Component<IDeploymentFormProps, IDeploymentFo | |||
| public render() { | |||
| const { selected, bindingsWithSecrets, chartID, chartVersion, namespace } = this.props; | |||
| const { version, versions } = selected; | |||
| const { appValues, releaseName } = this.state; | |||
| const { appValues } = this.state; | |||
There was a problem hiding this comment.
why not grab latestSubmittedReleaseName here too?
andresmgot
approved these changes
Nov 8, 2018
| expect(wrapper.find(ErrorSelector).exists()).toBe(true); | ||
| expect(wrapper.find(ErrorSelector).html()).toContain(expectedErrorMsg); | ||
| wrapper.setState({ releaseName: "my-app2" }); | ||
| expect(wrapper.find(ErrorSelector).html()).toContain(expectedErrorMsg); |
There was a problem hiding this comment.
this assertion won't fail even if the bug is still present (since you are appending just a 2), you'll need to use a completely different name for the releaseName or use .not.toContain("my-app2").
There was a problem hiding this comment.
ahaaa, good catch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch decouples the releaseName used in the controlled field in the form from the releaseName shown in the error message.
Fixes #757