Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install CRDs by using the new crd-install hook #821

Merged
merged 6 commits into from
Nov 14, 2018

Conversation

migmartri
Copy link
Contributor

@migmartri migmartri commented Nov 14, 2018

NOTE: This is an alternative approach to #820

Helm 2.10 allows installing CRDs in a controlled way which seems to fix our issue #819

I have managed to successfully complete this scenario #813 in GKE by using an upgraded version of Helm.

A side effect of using this hook is that now we do not need the bootstrap job and we can add the repositories in pre or post install.

$ helm version
Client: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}
Server: &version.Version{SemVer:"v2.11.0", GitCommit:"2e55dbe1fdb5fdb96b75ff144a339489417b146b", GitTreeState:"clean"}

The patch also adds the requirement in the Chart.yaml file so it is clear that there is a min requirement to make it work.

NOTE: "helm.sh/hook": crd-install is only applied on installation so if you delete the crd and then update it will not get created. It does not update it either.

Fixes #819

Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, check to see if we can remove the bootstrap job. We should also add documentation about the minimum version of Helm we support in the README, getting started and Helm chart README (feel free to do that in a separate PR).

@migmartri migmartri merged commit 705857e into vmware-tanzu:master Nov 14, 2018
@migmartri migmartri deleted the 819-crd-fix-install-crd-hook branch November 14, 2018 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to decode "": no kind "CustomResourceDefinition"
2 participants