Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assign dynamically available local port for port-forward call #86

Merged
merged 2 commits into from
Dec 6, 2017
Merged

assign dynamically available local port for port-forward call #86

merged 2 commits into from
Dec 6, 2017

Conversation

ngtuna
Copy link
Contributor

@ngtuna ngtuna commented Dec 5, 2017

fix #82

cc/ @prydonius

prydonius
prydonius suggested changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, the only change I would make here is to keep the --port flag to allow me to specify a custom port override.

@ngtuna
Copy link
Contributor Author

ngtuna commented Dec 6, 2017

@prydonius 👍 updated. PTAL

prydonius
prydonius approved these changes Dec 6, 2017
View reviewed changes
Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ngtuna ngtuna merged commit 51c8141 into vmware-tanzu:master Dec 6, 2017
prydonius pushed a commit to prydonius/kubeapps that referenced this pull request Mar 5, 2018
@sozercan @prydonius
Checking for service catalog and service brokers installation and dep…
9be3ea2 
…loyed service instances (vmware-tanzu#86)

* checks for service catalog, service brokers and service instances

* review changes

* moving checkCatalogInstalled into an action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prydonius prydonius prydonius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeapps dashboard dynamic local port allocation
2 participants
@ngtuna @prydonius