Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show error message for unexpected errors #866

Merged
merged 2 commits into from
Dec 5, 2018

Conversation

andresmgot
Copy link
Contributor

Fixes #856

Shows the cause of the error for the UnexpectedError page.

Additional change: To ensure we don't show the generic message by mistake in some view, now it's explicitly necessary to set its flag (showGenericMessage ) to true to render it.

screenshot 2018-12-04 at 13 33 27

Copy link
Contributor

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is showGenericMessage={false} ever used? If not, I'd remove the feature and always show the GenericMessage alongwith the raw error.

Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe showGenericMessage={false} is used (set by defaultProps) when we don't only want to show the raw error message.

@andresmgot
Copy link
Contributor Author

Yes, it's used in several places like in the PermissionErrorAlert. It's not necessary now because the default is false now but I think it's useful to be explicit.

@andresmgot andresmgot merged commit 753f705 into vmware-tanzu:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants