source script in the specific step #871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresmgot
reviewed
Dec 6, 2018
| @@ -192,6 +192,7 @@ gke_test: &gke_test | |||
| - run: | | |||
| # If we want to test the latest version instead we override the image to be used | |||
| if [[ -n "$TEST_LATEST_RELEASE" ]]; then | |||
| source ./script/chart_sync_utils.sh | |||
| # latestReleaseTag was sourced in the first step via chart_sync_utils | |||
There was a problem hiding this comment.
you forgot to remove this comment
|
thanks for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try if sourcing the script in the step is now required and fixes the issue shown here #870
This might not be the final fix but it might unblock our release process when we land code in master.
Closes #870