Fix comparison issue

[carrodher]

Fixes bitnami/charts#1007:

at <ne .path "/">: error calling ne: invalid type for comparison

This error appears because if a value is unset, it is returned as a nil value, so we need to replace

-{{- if ne .path "/" -}}
+{{- if (.path) and ne .path "/" -}}

[prydonius]

Hmm, that value is set by default. What values are you using that make it unset? I'm wondering if we should be okay requiring that to be set.

[carrodher]

Hmm, that value is set by default. What values are you using that make it unset? I'm wondering if we should be okay requiring that to be set.

Using

helm install --name kubeapps --namespace kubeapps bitnami/kubeapps \
   --set ingress.enabled=true \
   --set ingress.certManager=true \
   --set ingress.hosts[0].name=kubeapps.mydomain.com \
   --set ingress.hosts[0].tls=true \
   --set ingress.hosts[0].tlsSecret=kubeapps-tls

as it is indicated in the readme, it doesn't work

[migmartri]

Thanks for the fix!

I always forget that since we are using an array of ingresses you need to put all the fields during overrides.

Out of curiosity, why are we supporting in our charts more than one ingress? Is this something that people have been asking for?

[prydonius]

Another option here would have been to update the readme to correctly set path btw, I think it can make sense to error out if that isn't set.

[prydonius]

Looks like this condition is wrong and is producing the rewrite rule even when path = "/", which ends up causing a redirect loop in Kubeapps. Just checked and the correct way to do this is:

{{- if .path -}}
{{- if ne .path "/" -}}
      rewrite ^({{ .path }})$ $1/ permanent;
{{- end -}}
{{- end -}}

However with #910, we may not need to fix this condition.