Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to set up an OIDC proxy in the chart #968

Merged
merged 3 commits into from
Feb 22, 2019

Conversation

andresmgot
Copy link
Contributor

@andresmgot andresmgot commented Feb 21, 2019

Fixes #949

Changes in the chart that allow users to install an OIDC proxy (keycloak-gatekeeper) with the Kubeapps chart. The proxy is run as a sidecar container in the frontend deployment.

I am waiting for #967 to be landed before adding some documentation about how this can be used in the document using-an-OIDC-provider.md.

This PR is ready to be reviewed but should not be merged until a new version of Kubeapps is available.

Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, this looks great. We can merge this as the chart update after releasing Kubeapps with the auth changes

@andresmgot
Copy link
Contributor Author

@prydonius I have added a bit of documentation to cover the chart options to set the OIDC proxy, please take a look and let me know if you have any suggestions, I can do that in a follow-up PR.

@andresmgot andresmgot merged commit c297766 into vmware-tanzu:master Feb 22, 2019
@prydonius
Copy link
Contributor

@andresmgot looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants