Add global imagePullSecrets to overwrite any other existing one #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 12, 2019 14:41
Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
andresmgot
reviewed
Mar 12, 2019
added 2 commits
March 12, 2019 15:46
Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
andresmgot
approved these changes
Mar 12, 2019
Signed-off-by: Carlos Rodriguez Hernandez <crhernandez@bitnami.com>
|
Thanks for the PR @carrodher |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Carlos Rodriguez Hernandez crhernandez@bitnami.com
What this PR does/why we need it:
This PR allows using a global parameter to indicate the array of secret names to use as Image Registry Secret.
Use:
Specify a secret globally for a specific registry, in this way, we are able to modify the registry and the secret for pulling images for all Charts globally without having to specify this per image