Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add builds for GKE 1.12 #998

Merged
merged 5 commits into from
Mar 22, 2019
Merged

Add builds for GKE 1.12 #998

merged 5 commits into from
Mar 22, 2019

Conversation

andresmgot
Copy link
Contributor

@andresmgot andresmgot commented Mar 21, 2019

Fixes #886

Example build: https://circleci.com/workflow-run/d8a54f97-f424-4d56-88d1-a1e36607bedb

I have also added the label team=kubeapps for accounting purposes

@andresmgot andresmgot requested a review from prydonius March 21, 2019 12:02
Copy link
Contributor

@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks for jumping on this! Please fix the missing dependency for the release job

- push_images:
<<: *build_always
requires:
- GKE_1_11_MASTER
- GKE_1_11_LATEST_RELEASE
- GKE_1_12_MASTER
- GKE_1_12_LATEST_RELEASE
- release:
<<: *build_on_tag
requires:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be dependent on it too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch

@andresmgot andresmgot merged commit bf6bcd7 into master Mar 22, 2019
@prydonius prydonius deleted the GKE1.12 branch March 22, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants