Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick #312 and #310 #316

Merged

Conversation

lubronzhan
Copy link
Contributor

Cherry pick #312 and #310

Signed-off-by: dependabot[bot] support@github.comWhat this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Describe testing done for PR:

Special notes for your reviewer:

Release note:


New PR Checklist

  • Ensure PR contains only public links or terms
  • Use good commit messages
  • Squash the commits in this branch before merge to preserve our git history
  • If this PR is just an idea or POC, use a Draft PR instead of a full PR
  • Add appropriate labels according to what type of issue is being addressed.Signed-off-by: Lubron Zhan lubronzhan@gmail.com

Signed-off-by: Lubron Zhan <lubronzhan@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 5.55556% with 34 lines in your changes missing coverage. Please review.

Project coverage is 31.74%. Comparing base (b237b79) to head (c9de7f7).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-1.12     #316      +/-   ##
================================================
- Coverage         31.81%   31.74%   -0.08%     
================================================
  Files                31       32       +1     
  Lines              2907     2914       +7     
================================================
  Hits                925      925              
- Misses             1912     1919       +7     
  Partials             70       70              
Files Coverage Δ
pkg/haprovider/haprovider.go 70.35% <100.00%> (ø)
.../akodeploymentconfig/cluster/cluster_controller.go 0.00% <0.00%> (ø)
...deploymentconfig/akodeploymentconfig_controller.go 0.00% <0.00%> (ø)
...ollers/akodeploymentconfig/user/user_controller.go 7.85% <0.00%> (ø)
...tconfig/cluster/cluster_controller_addon_secret.go 14.69% <16.66%> (+0.40%) ⬆️
pkg/utils/get_objects.go 0.00% <0.00%> (ø)
main.go 0.00% <0.00%> (ø)

@lubronzhan lubronzhan merged commit f25eb50 into vmware-tanzu:release-1.12 Jun 26, 2024
5 checks passed
@lubronzhan lubronzhan deleted the topic/lubron/cherrypick_fix branch June 26, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants