Add MatchExpression support for SecurityPolicy #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To add UT later. |
timdengyun
force-pushed
the
AddMatchExpressionSupport
branch
from
0ec398d to
0cbaa4b
Compare
dantingl
reviewed
Jan 20, 2022
timdengyun
force-pushed
the
AddMatchExpressionSupport
branch
from
0cbaa4b to
5994811
Compare
heypnus
reviewed
Jan 21, 2022
dantingl
reviewed
Jan 21, 2022
heypnus
reviewed
Jan 21, 2022
timdengyun
force-pushed
the
AddMatchExpressionSupport
branch
from
5994811 to
dc0a843
Compare
timdengyun
force-pushed
the
AddMatchExpressionSupport
branch
5 times, most recently
from
db45a65 to
796d61f
Compare
heypnus
reviewed
Jan 27, 2022
timdengyun
force-pushed
the
AddMatchExpressionSupport
branch
from
796d61f to
c3e02db
Compare
timdengyun
force-pushed
the
AddMatchExpressionSupport
branch
2 times, most recently
from
89abb20 to
3f6eb15
Compare
heypnus
reviewed
Jan 28, 2022
1.Support MatchExpression Operator: 'NotIn', 'Exists', 'DoesNotExist' for VM/Pod/Namespace label selectors in SecurityPolicy 2.Given NSX doesn't support MatchExpression Operator 'In', and only five criteria are allowed currently, which results into a gigantic group expression body to be passed to NSX. So, only allow just one Operator 'In' MatchExpressions with at most of five values in it. 3.Add NSX-T limitation and NSGroup Criteria check
timdengyun
force-pushed
the
AddMatchExpressionSupport
branch
from
3f6eb15 to
a99a9b7
Compare
timdengyun
force-pushed
the
AddMatchExpressionSupport
branch
from
a99a9b7 to
c6fb922
Compare
heypnus
approved these changes
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Support MatchExpression Operator: 'NotIn', 'Exists',
'DoesNotExist' for VM/Pod/Namespace label selectors
in SecurityPolicy
2.Given NSX doesn't support MatchExpression Operator 'In',
and only five criteria are allowed currently,
which results into a gigantic group expression body to be passed to NSX.
So, only allow just one Operator 'In' MatchExpressions with at most
of five values in it.
3.Add NSX-T limitation and NSGroup Criteria check