Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Roundtrip should only return err from base().RoundTrip #48

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Roundtrip should only return err from base().RoundTrip #48

merged 1 commit into from
Feb 8, 2022

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Jan 27, 2022

Update some log info

@TaoZou1 TaoZou1 force-pushed the error branch 2 times, most recently from 8328eb5 to 0955a11 Compare January 28, 2022 02:17
@TaoZou1
Roundtrip should only return err from base().RoundTrip
7997527 
Update some log output
Remove unused test case from transport_test.go
@TaoZou1 TaoZou1 requested review from heypnus and dantingl February 7, 2022 01:50
dantingl
dantingl approved these changes Feb 8, 2022
View reviewed changes
Copy link
Contributor

@dantingl dantingl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoZou1 TaoZou1 merged commit 7f95d9b into vmware-tanzu:main Feb 8, 2022
@TaoZou1 TaoZou1 deleted the error branch November 30, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dantingl dantingl dantingl approved these changes

@heypnus heypnus Awaiting requested review from heypnus

Assignees
No one assigned
Labels
cla-not-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TaoZou1 @dantingl @vmwclabot