Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DHCP validation #875

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

yanjunz97
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.61%. Comparing base (bf1880a) to head (094a05d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #875   +/-   ##
=======================================
  Coverage   70.61%   70.61%           
=======================================
  Files          95       95           
  Lines       15094    15094           
=======================================
  Hits        10658    10658           
  Misses       3710     3710           
  Partials      726      726           
Flag Coverage Δ
unit-tests 70.61% <ø> (ø)

Signed-off-by: Yanjun Zhou <yanjun.zhou@broadcom.com>
@yanjunz97 yanjunz97 force-pushed the fix-dhcp-validation branch from 4dae345 to 094a05d Compare November 7, 2024 05:46
Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanjunz97 yanjunz97 merged commit 6c7a5dd into vmware-tanzu:main Nov 7, 2024
1 of 2 checks passed
yanjunz97 added a commit to yanjunz97/nsx-operator that referenced this pull request Nov 7, 2024
Signed-off-by: Yanjun Zhou <yanjun.zhou@broadcom.com>
yanjunz97 added a commit that referenced this pull request Nov 8, 2024
Signed-off-by: Yanjun Zhou <yanjun.zhou@broadcom.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants