-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check more resources realized status when creating subnet #921
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #921 +/- ##
==========================================
+ Coverage 73.26% 73.40% +0.13%
==========================================
Files 109 109
Lines 15095 15253 +158
==========================================
+ Hits 11059 11196 +137
- Misses 3284 3306 +22
+ Partials 752 751 -1
|
6e4d6ed
to
3705969
Compare
/e2e |
Subnet includes child resources which also need checking realized status. Check subnet for all child resources
ffccbb6
to
5259e2b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Subnet includes child resources which also need checking realized status.
Add RealizedLogicalPort, RealizedLogicalRouterPort checking