Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error check in service_lb_controller #942

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Dec 4, 2024

Add more error check in service_lb_controller

Add more error check in service_lb_controller
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 58.62069% with 12 lines in your changes missing coverage. Please review.

Project coverage is 73.83%. Comparing base (278aaf3) to head (9d193e9).

Files with missing lines Patch % Lines
pkg/controllers/service/service_lb_controller.go 58.62% 10 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           v4.2.0     #942      +/-   ##
==========================================
- Coverage   73.88%   73.83%   -0.06%     
==========================================
  Files         109      109              
  Lines       15269    15285      +16     
==========================================
+ Hits        11282    11286       +4     
- Misses       3238     3248      +10     
- Partials      749      751       +2     
Flag Coverage Δ
unit-tests 73.83% <58.62%> (-0.06%) ⬇️
Files with missing lines Coverage Δ
pkg/controllers/service/service_lb_controller.go 60.00% <58.62%> (-5.96%) ⬇️

@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Dec 6, 2024

/e2e

@TaoZou1 TaoZou1 requested a review from timdengyun December 6, 2024 08:05
Copy link
Contributor

@timdengyun timdengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TaoZou1 TaoZou1 merged commit c1e4b35 into vmware-tanzu:v4.2.0 Dec 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants