Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove entityType from CheckRealizeState #950

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

TaoZou1
Copy link
Contributor

@TaoZou1 TaoZou1 commented Dec 10, 2024

Remove entityType from CheckRealizeState. Since we're not sure if the realized
items for intentPath will be changed or not

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.50%. Comparing base (21d1300) to head (5720560).

Files with missing lines Patch % Lines
pkg/nsx/services/vpc/vpc.go 0.00% 3 Missing ⚠️
pkg/nsx/services/subnet/subnet.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #950   +/-   ##
=======================================
  Coverage   73.49%   73.50%           
=======================================
  Files         108      108           
  Lines       15276    15274    -2     
=======================================
  Hits        11227    11227           
+ Misses       3298     3297    -1     
+ Partials      751      750    -1     
Flag Coverage Δ
unit-tests 73.50% <50.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
pkg/nsx/services/realizestate/realize_state.go 100.00% <100.00%> (+5.00%) ⬆️
pkg/nsx/services/subnetport/subnetport.go 80.83% <100.00%> (ø)
pkg/nsx/services/subnet/subnet.go 66.66% <0.00%> (ø)
pkg/nsx/services/vpc/vpc.go 56.16% <0.00%> (ø)

@zhengxiexie
Copy link
Contributor

/e2e

Copy link
Contributor

@yanjunz97 yanjunz97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM, just found one typo

Remove entityType from CheckRealizeState. Since we're not sure if the
realized items for intentPath will be changed or not
@TaoZou1
Copy link
Contributor Author

TaoZou1 commented Dec 10, 2024

/e2e

@wenyingd wenyingd merged commit 7230790 into vmware-tanzu:main Dec 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants