Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ut in Subnet/SubnetSet controllers related with SubnetConnectionBindingMaps #964

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wenyingd
Copy link
Contributor

  1. Add unit test in Subnet/SubnetSet controllers related with SubnetConnectionBindingMaps
  2. Add unit test in SubnetConnectionBindingMaps services to verify the paging logic

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.08%. Comparing base (0222a3d) to head (ba75f76).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #964      +/-   ##
==========================================
+ Coverage   73.42%   74.08%   +0.65%     
==========================================
  Files         118      118              
  Lines       16392    16392              
==========================================
+ Hits        12036    12144     +108     
+ Misses       3571     3472      -99     
+ Partials      785      776       -9     
Flag Coverage Δ
unit-tests 74.08% <ø> (+0.65%) ⬆️

see 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants