Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor and fix comments #2061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor and fix comments #2061

wants to merge 1 commit into from

Conversation

ashish-amarnath
Copy link
Member

Release note:


Copy link

netlify bot commented Sep 19, 2024

Deploy Preview for pinniped-dev canceled.

Name Link
🔨 Latest commit ab2c2e3
🔍 Latest deploy log https://app.netlify.com/sites/pinniped-dev/deploys/66ec8bcf9d94f50008f8b818

Signed-off-by: Ashish Amarnath <ashish.amarnath@broadcom.com>
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 31.14%. Comparing base (65b93f0) to head (ab2c2e3).

Files with missing lines Patch % Lines
internal/upstreamldap/upstreamldap.go 85.71% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2061   +/-   ##
=======================================
  Coverage   31.13%   31.14%           
=======================================
  Files         368      368           
  Lines       60970    60971    +1     
=======================================
+ Hits        18985    18988    +3     
+ Misses      41461    41458    -3     
- Partials      524      525    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants