Minor fixes in makefiles #1000
Merged
Minor fixes in makefiles #1000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the API requested a non-existent secret, the error message we got was too alarming and confusing. This commit softens that message and provides additional context. Signed-off-by: Volkan Ozcelik <me@volkan.io>
Signed-off-by: Volkan Ozcelik <me@volkan.io>
Signed-off-by: Volkan Ozcelik <me@volkan.io>
v0lkan
commented
Jun 15, 2024
| @@ -93,7 +93,8 @@ func Fetch( | |||
|
|
|||
| secret, err := collection.ReadSecret(cid, workloadId) | |||
| if err != nil { | |||
| log.WarnLn(&cid, "Fetch: Problem reading secret", err.Error()) | |||
| log.WarnLn(&cid, "Fetch: Attemted to read secret from disk.") | |||
| log.TraceLn(&cid, "Likely expected error. No need to panic:", err.Error()) | |||
There was a problem hiding this comment.
This message looked like a severe error and was confusing the developer when debugging the system behavior.
Renamed it to make it look intentionally less alarming.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor fixes in makefiles